pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14360 )
Change subject: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support ...................................................................... Patch Set 6: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/14360/6/include/osmocom/gsm/protocol/gsm_48_049.h File include/osmocom/gsm/protocol/gsm_48_049.h: https://gerrit.osmocom.org/#/c/14360/6/include/osmocom/gsm/protocol/gsm_48_049.h@119 PS6, Line 119: /* not explicitly specified, but every message starts with those mandatory eleemnts */ Typo not fixed. https://gerrit.osmocom.org/#/c/14360/6/src/gsm/gsm48049.c File src/gsm/gsm48049.c: https://gerrit.osmocom.org/#/c/14360/6/src/gsm/gsm48049.c@112 PS6, Line 112: Not sure if there's a bug with gerrit here, but I used to see more stuff behind, and after adding my comment I was unable to see it? or maybe I'm confused myself I don't know. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5b7ae08f67e415967b60ac4b824db9e22ca00935 Gerrit-Change-Number: 14360 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Fri, 19 Jul 2019 11:12:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
