fixeria has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-trx/+/14845 )
Change subject: trxd_fill_common(): fix TRXD header version coding
......................................................................
trxd_fill_common(): fix TRXD header version coding
The header version field is 4 bit long, so the mask 0x07 == 0b111
is wrong, it should actually be 0x0f == 0b1111.
Change-Id: I290931559ce01cf6e43470b18855c46808d6c2a5
---
M Transceiver52M/proto_trxd.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/Transceiver52M/proto_trxd.c b/Transceiver52M/proto_trxd.c
index cd82d55..fbef77a 100644
--- a/Transceiver52M/proto_trxd.c
+++ b/Transceiver52M/proto_trxd.c
@@ -27,7 +27,7 @@
static void trxd_fill_common(struct trxd_hdr_common *common, const struct
trx_ul_burst_ind *bi, uint8_t version)
{
- common->version = version & 0x07;
+ common->version = version & 0b1111;
common->reserved = 0;
common->tn = bi->tn;
osmo_store32be(bi->fn, &common->fn);
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14845
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I290931559ce01cf6e43470b18855c46808d6c2a5
Gerrit-Change-Number: 14845
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
