fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14853 )
Change subject: mobile: Fix encoding of cause in gsm480_tx_release_compl() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/14853/1/src/host/layer23/src/mobile/gsm480_ss.c File src/host/layer23/src/mobile/gsm480_ss.c: https://gerrit.osmocom.org/#/c/14853/1/src/host/layer23/src/mobile/gsm480_ss.c@404 PS1, Line 404: tlv[2] = 0x80 | cause; : tlv[3] = 0x80 | GSM48_CAUSE_LOC_USER; An idea for another change: cause should actually go after location. Please see section 10.5.4.11, and https://git.osmocom.org/osmo-msc/tree/src/libmsc/gsm_04_80.c#n88. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14853 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iba2ace7d82be5677d28b25f60ab0312fed76f5e5 Gerrit-Change-Number: 14853 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Comment-Date: Sun, 21 Jul 2019 08:48:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
