laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-pcu/+/14858 )
Change subject: bssgp: Fix dead code: PDUT_STATUS can never reach this part
......................................................................
bssgp: Fix dead code: PDUT_STATUS can never reach this part
Change-Id: Iae4332cd3b87f37164655d3df16554de4876159d
Closes: CID#188855
---
M src/gprs_bssgp_pcu.cpp
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp
index a4a5875..b34659b 100644
--- a/src/gprs_bssgp_pcu.cpp
+++ b/src/gprs_bssgp_pcu.cpp
@@ -369,9 +369,7 @@
if (rc < 0) {
LOGP(DBSSGP, LOGL_ERROR, "Failed to parse BSSGP %s message.
Invalid message was: %s\n",
bssgp_pdu_str(pdu_type), msgb_hexdump(msg));
- if (pdu_type != BSSGP_PDUT_STATUS)
- return bssgp_tx_status(BSSGP_CAUSE_INV_MAND_INF, NULL,
msg);
- return rc;
+ return bssgp_tx_status(BSSGP_CAUSE_INV_MAND_INF, NULL, msg);
}
if (pdu_type == BSSGP_PDUT_BVC_RESET) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14858
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iae4332cd3b87f37164655d3df16554de4876159d
Gerrit-Change-Number: 14858
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-MessageType: merged
