pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14840 )
Change subject: doc: Add Osmux documentation to User Manual ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/14840/1/doc/manuals/chapters/osmux_bsc.adoc File doc/manuals/chapters/osmux_bsc.adoc: https://gerrit.osmocom.org/#/c/14840/1/doc/manuals/chapters/osmux_bsc.adoc@7 PS1, Line 7: In this kind of setup, Osmux is transparent to {program-name} and no specific > What is the advantage of using {program-name}? Since this file is not in > common, it will always be O […] This way I make sure same content is used everywhere without needing to care about how we really want to call the program, be it osmobsc, OsmoBSC, osmo-bsc, osmo-nitb, whatever. It also makes it easier in case you want to re-use it for other programs/processes. I'll change hardcoded OsmoBSC ones into {program-name}. https://gerrit.osmocom.org/#/c/14840/1/doc/manuals/chapters/osmux_bsc.adoc@18 PS1, Line 18: appending the _Osmux Support_ IE in _BSSMAP RESET_ and _BSSMAP RESET ACK_ > same comment about non-standard nature of the IE applies here, also the > comment about recommending t […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14840 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I75dcdddc713b0dc43e2ba577ca377c20fc511f38 Gerrit-Change-Number: 14840 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: osmith <[email protected]> Gerrit-Comment-Date: Mon, 22 Jul 2019 08:03:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: osmith <[email protected]> Gerrit-MessageType: comment
