osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14894 )
Change subject: OBS: print date/time before git clone and on error ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14894/1/scripts/common.sh File scripts/common.sh: https://gerrit.osmocom.org/#/c/14894/1/scripts/common.sh@96 PS1, Line 96: if ! git clone "$@"; then > I think you should not use "" here. "$@" must be quoted in order to pass the parameters without change. Here's an example: #!/bin/sh in_quotes() { echo "in quotes:" for i in "$@"; do echo "arg: $i" done } not_in_quotes() { echo "not in quotes:" for i in $@; do echo "arg: $i" done } in_quotes "a b" c d not_in_quotes "a b" c d This yields: in quotes: arg: a b arg: c arg: d not in quotes: arg: a arg: b arg: c arg: d See also: https://www.tldp.org/LDP/abs/html/internalvariables.html -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic9a6d3f0c2b8dad2661ede793c21307f1680a52e Gerrit-Change-Number: 14894 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Tue, 23 Jul 2019 06:21:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
