osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901 )
Change subject: msc: check IMEI: move reject LU into new function ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14901/1/msc/BSC_ConnectionHandler.ttcn File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/#/c/14901/1/msc/BSC_ConnectionHandler.ttcn@645 PS1, Line 645: f_reject_lu > I would rather call it f_exp_lu_reject(), as we don't reject anything here, > but expect this message […] Good idea! I went with f_expect_lu_reject for consistency with other functions in BSC_ConnectionHandler.ttcn. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifad259e21df035a89e97831a57c0675502308eb6 Gerrit-Change-Number: 14901 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Tue, 23 Jul 2019 13:09:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
