keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14922 )
Change subject: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14922/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/#/c/14922/1/src/gprs_bssgp_pcu.cpp@123 PS1, Line 123: gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), > I think you never get to the code below if imsi is not set, we crash first. Ah you mean after this patch? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I940d220a399166122f33e67a222dd572085e1401 Gerrit-Change-Number: 14922 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Wed, 24 Jul 2019 11:12:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: keith <[email protected]> Gerrit-MessageType: comment
