fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/gr-gsm/+/14948 )
Change subject: Fix uplink sub_slot and sub_types assignment in the sdcch4 and bcch_ccch demappers blocks ...................................................................... Patch Set 1: In general, I am find with the proposed patch set. But instead of having magic calculations in the original code, I would rather follow the way of OsmoBTS, which I followed in trxcon: https://git.osmocom.org/osmocom-bb/tree/src/host/trxcon/sched_mframe.c Ideally, we need to share this code somewhere in libosmogsm, so then it can be used by gr-gsm, and even by OsmoTRX. -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14948 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: Ia6b3070c1085bcdda6d98fd94a89c6e0982e2aec Gerrit-Change-Number: 14948 Gerrit-PatchSet: 1 Gerrit-Owner: vvvelichkov <[email protected]> Gerrit-Reviewer: Piotr Krysik <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Comment-Date: Fri, 26 Jul 2019 12:39:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
