pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14973 )
Change subject: vty/vty.c: fix vty_execute(): prevent further heap-buffer overrun ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/14973/1/src/vty/vty.c File src/vty/vty.c: https://gerrit.osmocom.org/#/c/14973/1/src/vty/vty.c@690 PS1, Line 690: vty->buf[vty->length] = '\0'; Rather move this to vty_read(), immediately before read() call. Let's assume in vty_execute that vty->buf is null-terminate, that'd be more sane for everybody. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82f774ad18d0e555eb8f3590a519946d9c583c78 Gerrit-Change-Number: 14973 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Mon, 29 Jul 2019 12:54:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
