neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14769 )
Change subject: neighbor config: allow re-using ARFCN+BSIC pairs ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14769/1/src/osmo-bsc/handover_decision_2.c File src/osmo-bsc/handover_decision_2.c: https://gerrit.osmocom.org/#/c/14769/1/src/osmo-bsc/handover_decision_2.c@903 PS1, Line 903: find_handover_target_cell(&neighbor_bts, &neighbor_cil, > no check for return code? the return values neighbor_bts and neighbor_cil are checked, they will both be NULL for any errors. Also, this is just collecting candidates, so it should not raise error logs, rather just yield no candidates. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14769 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29bca59ab232eddc74e0d4698efb9c9992443983 Gerrit-Change-Number: 14769 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Mon, 29 Jul 2019 16:14:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
