laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14768 )
Change subject: add vty 'no neighbors' to remove all HO targets ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/14768/1/src/osmo-bsc/neighbor_ident_vty.c File src/osmo-bsc/neighbor_ident_vty.c: https://gerrit.osmocom.org/#/c/14768/1/src/osmo-bsc/neighbor_ident_vty.c@410 PS1, Line 410: while (1) { : struct gsm_bts_ref *neigh = llist_first_entry_or_null(&bts->local_neighbors, struct gsm_bts_ref, entry); > This is a style bikeshed... […] Call it bikeshed, but I'm always for using the designated API of a given sub-system (linuxlist.h here) than manual constructs. You're free to ignore this, https://gerrit.osmocom.org/#/c/14768/1/src/osmo-bsc/neighbor_ident_vty.c@432 PS1, Line 432: neighbor_ident_iter(g_neighbor_cells, nil_match_bts, &d); > BTW, when inventing the neighbor_ident, I wanted the API as opaque as > possible, which seemed to be a […] In terms of style, I also don't think we have any iterator functions in other osmocom code, but generally the "list user" iterates open/manually over the llist_head -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8623ab581639e9f8af6a9ff1eca990518d1b1211 Gerrit-Change-Number: 14768 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Mon, 29 Jul 2019 18:20:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
