Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 )
Change subject: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT ...................................................................... Patch Set 2: Code-Review+1 (3 comments) https://gerrit.osmocom.org/#/c/14940/2/common/chapters/trx_if.adoc File common/chapters/trx_if.adoc: https://gerrit.osmocom.org/#/c/14940/2/common/chapters/trx_if.adoc@257 PS2, Line 257: express that in centiBels I think this part needs to be corrected, because "the ideal training sequence can be compared ... and then express ...". https://gerrit.osmocom.org/#/c/14940/2/common/chapters/trx_if.adoc@319 PS2, Line 319: +-----------------+---------------------------------------+ > . 1 1 0 X seems to be missing. […] Right, thanks! Let's also mark it as reserved. https://gerrit.osmocom.org/#/c/14940/2/common/chapters/trx_if.adoc@325 PS2, Line 325: used to decode the burst This only applies to Access and Synchronization bursts, but not to Normal bursts. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I320539fc9ffb7dd0f09ec18892299bd603cd7a85 Gerrit-Change-Number: 14940 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: daniel <[email protected]> Gerrit-Comment-Date: Tue, 30 Jul 2019 01:37:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: daniel <[email protected]> Gerrit-MessageType: comment
