neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14995 )
Change subject: Prepare to support MO Call HOLD ...................................................................... Patch Set 3: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/14995/3/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/14995/3/src/sip.c@481 PS3, Line 481: char *sdp = sdp_create_file(leg, other_leg, sdp_sendonly); (I know, but osmocom style would require declaring the char* sdp at the top.) https://gerrit.osmocom.org/#/c/14995/3/src/sip.c@491 PS3, Line 491: static void sip_retrieve_call(struct call_leg *_leg) (this is mostly code dup from above, but ok) -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I2595626dfa50eb2f8e29a02540b708c9c1dce88c Gerrit-Change-Number: 14995 Gerrit-PatchSet: 3 Gerrit-Owner: keith <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jul 2019 16:26:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
