dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/15007
Change subject: bsc_msc_data: remove unused member is_authenticated
......................................................................
bsc_msc_data: remove unused member is_authenticated
The struct member struct bsc_msc_data->is_authenticated is set to true
permanently. This is a leftover from the sccplite implementation and can
be removed now.
Change-Id: I966a48b383c85345c92c9a1fec791150e96cd7b9
Related: OS#3112
---
M include/osmocom/bsc/bsc_msc_data.h
M src/osmo-bsc/gsm_08_08.c
M src/osmo-bsc/osmo_bsc_msc.c
3 files changed, 0 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/07/15007/1
diff --git a/include/osmocom/bsc/bsc_msc_data.h
b/include/osmocom/bsc/bsc_msc_data.h
index 2ad7c68..5612483 100644
--- a/include/osmocom/bsc/bsc_msc_data.h
+++ b/include/osmocom/bsc/bsc_msc_data.h
@@ -77,7 +77,6 @@
int core_lac;
int core_ci;
int rtp_base;
- bool is_authenticated;
/* audio codecs */
struct gsm48_multi_rate_conf amr_conf;
diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c
index 6ca5455..4dc4883 100644
--- a/src/osmo-bsc/gsm_08_08.c
+++ b/src/osmo-bsc/gsm_08_08.c
@@ -307,8 +307,6 @@
round_robin:
llist_for_each_entry(msc, &bsc->mscs, entry) {
- if (!msc->is_authenticated)
- continue;
if (!is_emerg && msc->type != MSC_CON_TYPE_NORMAL)
continue;
if (is_emerg && !msc->allow_emerg)
diff --git a/src/osmo-bsc/osmo_bsc_msc.c b/src/osmo-bsc/osmo_bsc_msc.c
index 7e78d94..24c8c6d 100644
--- a/src/osmo-bsc/osmo_bsc_msc.c
+++ b/src/osmo-bsc/osmo_bsc_msc.c
@@ -49,13 +49,6 @@
uint16_t mgw_port;
int rc;
- /* FIXME: This is a leftover from the old architecture that used
- * sccp-lite with osmocom specific authentication. Since we now
- * changed to AoIP the connected status and the authentication
- * status is managed differently. However osmo_bsc_filter.c still
- * needs the flags to be set to one. See also: OS#3112 */
- msc->is_authenticated = 1;
-
if (net->mgw.conf->remote_port >= 0)
mgw_port = net->mgw.conf->remote_port;
else
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15007
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I966a48b383c85345c92c9a1fec791150e96cd7b9
Gerrit-Change-Number: 15007
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-MessageType: newchange
