fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15026 )
Change subject: codec/ecu: Introduce new generic Error Concealment Unit abstraction ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/15026/4/include/osmocom/codec/ecu.h File include/osmocom/codec/ecu.h: https://gerrit.osmocom.org/#/c/15026/4/include/osmocom/codec/ecu.h@45 PS4, Line 45: uint8_t data[0]; Not sure if it's a good idea to use a flexible array member here. Why not just a 'void *' pointer? What are the benefits of such strict co-allocation? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15026 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4d33c9c7c2d4c7462ff38a49c178b65accae1915 Gerrit-Change-Number: 15026 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Comment-Date: Thu, 01 Aug 2019 21:59:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
