laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-bts/+/14877 )
Change subject: scheduler_trx: Handle negative return of gsm0503_tch_hr_decode()
......................................................................
scheduler_trx: Handle negative return of gsm0503_tch_hr_decode()
If gsm0503_tch_hr_decode() returns a negative error, we shouldn't
set the marker bit or pass the negative value as length value into
osmo_hr_check_sid().
Change-Id: If49ca6926c576a2b17507b6a95b6f3ca17877d66
Closes: CID#187645
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c
index 532eca5..ef24119 100644
--- a/src/osmo-bts-trx/scheduler_trx.c
+++ b/src/osmo-bts-trx/scheduler_trx.c
@@ -1393,7 +1393,7 @@
*/
rc = gsm0503_tch_hr_decode(tch_data, *bursts_p,
fn_is_odd, &n_errors, &n_bits_total);
- if (rc) /* DTXu */
+ if (rc >= 0) /* DTXu */
lchan_set_marker(osmo_hr_check_sid(tch_data, rc),
lchan);
break;
case GSM48_CMODE_SPEECH_AMR: /* AMR */
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14877
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If49ca6926c576a2b17507b6a95b6f3ca17877d66
Gerrit-Change-Number: 14877
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-MessageType: merged
