pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15080 )
Change subject: Bump version: 0.5.0.2-6563 → 0.6.0 ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/15080/1/src/Makefile.am File src/Makefile.am: https://gerrit.osmocom.org/#/c/15080/1/src/Makefile.am@3 PS1, Line 3: 8:0:2 > is that safe with the new field that was added? probably, as it's compile > compatible, Good point. It breaks the ABI, so it's not compatible. Old programs will pass allocated structs being too small and libosmo-netif will write to wrong places. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/15080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I3af3b7aaff5c6dc3ac94e942191e27af4bf5392a Gerrit-Change-Number: 15080 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@gnumonks.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 07 Aug 2019 18:46:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <lafo...@gnumonks.org> Gerrit-MessageType: comment