keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142 )

Change subject: avoid bogus error logs when no cmd_timer is set
......................................................................


Patch Set 1:

> (2 comments)

hmm.. so I'm totally missing something.

They way I understand it, we set the timer because we expect something to 
happen. If that thing does not happen, or something else happens it it's place, 
then that is an unexpected condition, indicating that something went wrong.


Your log has:

20190809011936621 DMNCC DEBUG MNCC rcvd message type: MNCC_SETUP_COMPL_IND 
(mncc.c:946)
20190809011936621 DMNCC INFO leg(2147483649) is now connected. (mncc.c:627)
20190809011936622 DMNCC DEBUG Got response(MNCC_SETUP_COMPL_IND), stopping 
timer on leg(2147483649) (mncc.c:82)
20190809012014858 DMNCC DEBUG MNCC rcvd message type: MNCC_REL_CNF (mncc.c:946)

Why is the MSC sending MNCC_REL_CNF now? Something is out of sequence.

20190809012014859 DMNCC ERROR Wanted response(MNCC_RTP_CREATE) but 
got(MNCC_REL_CNF) for leg(5002) (mncc.c:76)

The commit message suggests this is random, but it looks precise to me. We 
wanted RTP_CREATE, but got REL_CNF.

I do not see this with nitb, and this MNCC send-expect logic was written to 
match it. I would assume something has happened in osmo-msc to change the 
sequence. This log message is showing that up.
hiding the log message does not seem like the way to go, either osmo-msc or 
sip-connector, should be fixed so that the sequence matches.


--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I70f85a71df55ab8618ed78864cefb6fe5b26f581
Gerrit-Change-Number: 15142
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@gnumonks.org>
Gerrit-Reviewer: neels <nhofm...@sysmocom.de>
Gerrit-CC: keith <ke...@rhizomatica.org>
Gerrit-Comment-Date: Wed, 14 Aug 2019 08:31:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to