keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142 )

Change subject: avoid bogus error logs when no cmd_timer is set
......................................................................


Patch Set 1:

Looking closer, Log is kind of hard on the eyes for sure, I see that we got the 
response (RTP_CREATE) and stopped the timer.
Maybe we should clear leg->rsp_wanted when we stop the timer, so that the LOG 
message can be more clear in that we got an UNEXPECTED or out of sequence 
command from the other side of the MNCC.

Maybe my knowledge of the MNCC sequence is missing something, but the 
osmo-sip-connector is only expecting MNCC_REL_CNF in response to it having sent 
a MNCC_REL_REQ. Is this wrong?


--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I70f85a71df55ab8618ed78864cefb6fe5b26f581
Gerrit-Change-Number: 15142
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@gnumonks.org>
Gerrit-Reviewer: neels <nhofm...@sysmocom.de>
Gerrit-CC: keith <ke...@rhizomatica.org>
Gerrit-Comment-Date: Wed, 14 Aug 2019 08:50:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to