pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15194 )

Change subject: library: S1AP encoding/decoding using libfftranscode and ASN.1 
from V15.5.0
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/15194/1/library/s1ap/S1AP_CommonDataTypes.asn
File library/s1ap/S1AP_CommonDataTypes.asn:

https://gerrit.osmocom.org/#/c/15194/1/library/s1ap/S1AP_CommonDataTypes.asn@10
PS1, Line 10: itu-t (0) identified-organization (4) etsi (0) mobileDomain (0)
whitespace


https://gerrit.osmocom.org/#/c/15194/1/library/s1ap/regen_makefile.sh
File library/s1ap/regen_makefile.sh:

https://gerrit.osmocom.org/#/c/15194/1/library/s1ap/regen_makefile.sh@7
PS1, Line 7: sed -i -e '/^CPPFLAGS/ s/$/ `pkg-config --cflags libfftranscode`/' 
Makefile
It would be great to add some check to make sure pkg-config finds 
libfftranscode so people can realize LD_LIBRARY_PATH is not corret (for 
instance, I have libfftranscode out of regular library paths).



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15194
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie019bef1f3ef9cc5f6c94a64c7f352c510fb5633
Gerrit-Change-Number: 15194
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Aug 2019 11:26:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to