neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/15209 )

Change subject: gsm_08_08.c: always pick first msc for unsolicit paging 
responses
......................................................................


Patch Set 1:

(2 comments)

agree to fix the Change-Id duality, otherwise +1 from me

https://gerrit.osmocom.org/#/c/15209/1/src/osmo-bsc/gsm_08_08.c
File src/osmo-bsc/gsm_08_08.c:

https://gerrit.osmocom.org/#/c/15209/1/src/osmo-bsc/gsm_08_08.c@328
PS1, Line 328:          LOGP(DMSC, LOGL_ERROR, "Got paged but no subscriber 
found, will now (blindly) deliver the paging response to the first configured 
MSC!\n");
s/Got paged/Got Paging Response ?


https://gerrit.osmocom.org/#/c/15209/1/src/osmo-bsc/gsm_08_08.c@358
PS1, Line 358:   * blindly. */
> As commented on other patch, shouldn't this be VTY configurable? (to which 
> MSC send them).
This entire code looks like weird legacy bsc-nat stuff, I've never used 
osmo-bsc with more than one MSC.
I think it makes a lot of sense to send the CSFB Paging Response to The One MSC.
The entire going through lists of MSCs is a legacy nonsense that we should 
probably remove anyway.

Correct me if I'm wrong (laforge?) but I think we don't need more vty for 
multiple MSC scenarios.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15209
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7f091ed1bbc2afe12656e42031e122144eeb6826
Gerrit-Change-Number: 15209
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilira...@gmail.com>
Gerrit-CC: neels <nhofm...@sysmocom.de>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Aug 2019 00:28:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to