pespin has posted comments on this change. ( )

Change subject: gprs_gmm: Introduce assert to guard against unexpected condition

Patch Set 2:

(1 comment)
File src/gprs/gprs_gmm.c:
PS2, Line 1747: mmctx->ran_type == MM_CTX_T_GERAN_Gb
> I'm also confused. […]
This is an assert I add to try to catch keith's osmo-sgsn isntance crashing (we 
started debugging it in OsmoDevCon). I don't want to directly workaround the 
issue, I really want osmo-sgsn to assert and exit in this situation, so we can 
make sure this is the condition he's hitting. Since lots of subscribers are 
using the sgsn at that time, it's impossible otherwise to find out.

Killing osmo-sgsn here is not a big issue since anyway it would crash later on 
due to the bug we spotted.

Regarding the assert condition:
If ran_type is MM_CTX_T_UTRAN_Iu, it's perfectly fine to have a null llme, so I 
really want to check in the Gb case (because anyway that's what's deployed in 
the setup where we saw the crash). I want to make sure that "it doesn't happen 
that llme is NULL when on Gb", and the condition expresses so.

The expression I'm using is exactly the same you are proposing. But Ok, I'll 
change it if you think it's simpler.

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I8e1eaeb9b3ebee8e45704b4fe007190c7db609e4
Gerrit-Change-Number: 15167
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <>
Gerrit-Reviewer: lynxis lazus <>
Gerrit-Reviewer: neels <>
Gerrit-Reviewer: pespin <>
Gerrit-CC: fixeria <>
Gerrit-Comment-Date: Thu, 15 Aug 2019 09:16:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <>
Comment-In-Reply-To: neels <>
Gerrit-MessageType: comment

Reply via email to