pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/13929 )
Change subject: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp ...................................................................... Patch Set 5: Code-Review-2 (1 comment) https://gerrit.osmocom.org/#/c/13929/5/src/gprs/sgsn_libgtp.c File src/gprs/sgsn_libgtp.c: https://gerrit.osmocom.org/#/c/13929/5/src/gprs/sgsn_libgtp.c@549 PS5, Line 549: if (!pdp) { That's for sure not the correct fix. It's fine receiving a null pdp, because we anyway need to free the cbp stuff. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/13929 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I184dcce27b26104c61d80b2d910388d5d3323def Gerrit-Change-Number: 13929 Gerrit-PatchSet: 5 Gerrit-Owner: keith <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <ke...@rhizomatica.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: fixeria <axilira...@gmail.com> Gerrit-CC: laforge <lafo...@gnumonks.org> Gerrit-CC: neels <nhofm...@sysmocom.de> Gerrit-Comment-Date: Thu, 15 Aug 2019 10:11:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
