pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15181 )
Change subject: iu_client: introduce a connection state ...................................................................... Patch Set 5: (2 comments) https://gerrit.osmocom.org/#/c/15181/5/src/iu_client.c File src/iu_client.c: https://gerrit.osmocom.org/#/c/15181/5/src/iu_client.c@119 PS5, Line 119: ctx->conn_state = RANAP_CONN_STATE_CONNECTED; How can it be connected here? because there's already a conn_id assigned which is expected to be an open connection? https://gerrit.osmocom.org/#/c/15181/5/src/iu_client.c@792 PS5, Line 792: /* indication of new inbound connection request*/ Shouldn't _alloc be DISCONNECTED and then in here set it to RANAP_CONN_STATE_CONNECTED? -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I77e01724be05ac488a4685ba367b7a71985b54e3 Gerrit-Change-Number: 15181 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Fri, 16 Aug 2019 10:24:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
