osmith has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15233 )
Change subject: Revert "RAN_Adapter: invert check for RAN_ops == omit"
......................................................................
Revert "RAN_Adapter: invert check for RAN_ops == omit"
This reverts commit 5932cd3463d04c45404c538daff6d25bc3f3d002. It caused
a lot of tests in the ttcn3-bsc-test, ttcn3-bsc-test-latest,
ttcn3-bsc-test-sccplite and ttcn3-bsc-test-sccplite-latest testsuites to
fail with:
RAN_Adapter.ttcnpp:179 Dynamic test case error: Text encoder: Encoding an
unbound optional value.
Related: OS#4156
Change-Id: I441c701553eef8e9e018d11923359eb3f3b26826
---
M library/RAN_Adapter.ttcnpp
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
osmith: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/library/RAN_Adapter.ttcnpp b/library/RAN_Adapter.ttcnpp
index 8e19241..e995e8d 100644
--- a/library/RAN_Adapter.ttcnpp
+++ b/library/RAN_Adapter.ttcnpp
@@ -90,7 +90,7 @@
/* create components */
ba.vc_SCCP := SCCP_CT.create(id & "-SCCP");
- if (not istemplatekind(ops, "omit")) {
+ if (isvalue(ops)) {
ba.vc_RAN := RAN_Emulation_CT.create(id & "-RAN");
}
select (cfg.transport) {
@@ -142,7 +142,7 @@
}
}
- if (not istemplatekind(ops, "omit")) {
+ if (isvalue(ops)) {
timer T := 5.0;
T.start;
//T.timeout;
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15233
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I441c701553eef8e9e018d11923359eb3f3b26826
Gerrit-Change-Number: 15233
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-MessageType: merged
