pespin has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15236 )

Change subject: sgsn: use sccp_simple_client API to setup ss7 id 0 instead of 1
......................................................................

sgsn: use sccp_simple_client API to setup ss7 id 0 instead of 1

Implementation of osmo_sccp_simple_client() API internally uses ss7 id
1, which is confusing since there's no 0 in use in osmo-sgsn. Let's
explicitly use the 0 one so it is configured by "cs7 instance 0" in the
VTY.

Related: OS#4157
Change-Id: I0e23a6a76ebcba0b1b424e3d3b20d06c1da44cbe
---
M src/gprs/sgsn_main.c
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/gprs/sgsn_main.c b/src/gprs/sgsn_main.c
index ecfb79b..5979886 100644
--- a/src/gprs/sgsn_main.c
+++ b/src/gprs/sgsn_main.c
@@ -500,11 +500,11 @@

 #if BUILD_IU
        /* Note that these are mostly defaults and can be overriden from the 
VTY */
-       sccp = osmo_sccp_simple_client(tall_sgsn_ctx, "OsmoSGSN",
-                                      (23 << 3) + 4,
-                                      OSMO_SS7_ASP_PROT_M3UA,
-                                      0, NULL,
-                                      0, "127.0.0.1");
+       sccp = osmo_sccp_simple_client_on_ss7_id(tall_sgsn_ctx, 0, "OsmoSGSN",
+                                                (23 << 3) + 4,
+                                                OSMO_SS7_ASP_PROT_M3UA,
+                                                0, NULL,
+                                                0, "127.0.0.1");
        if (!sccp) {
                printf("Setting up SCCP client failed.\n");
                return 8;

--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I0e23a6a76ebcba0b1b424e3d3b20d06c1da44cbe
Gerrit-Change-Number: 15236
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged

Reply via email to