osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15214 )
Change subject: Replace own timer infra with libosmocore osmo_tdef ...................................................................... Patch Set 2: Code-Review+1 (3 comments) https://gerrit.osmocom.org/#/c/15214/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15214/2//COMMIT_MSG@8 PS2, Line 8: How about mentioning the new VTY commands here? https://gerrit.osmocom.org/#/c/15214/2/src/gprs/gprs_gmm.c File src/gprs/gprs_gmm.c: https://gerrit.osmocom.org/#/c/15214/2/src/gprs/gprs_gmm.c@2287 PS2, Line 2287: empty line at start of function https://gerrit.osmocom.org/#/c/15214/2/src/gprs/gprs_gmm.c@2291 PS2, Line 2291: unrelated change -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia0cf5f0a49737fbc419e2ccc86312d01c6e0056e Gerrit-Change-Number: 15214 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 20 Aug 2019 10:48:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
