osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15029 )
Change subject: gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK ...................................................................... Patch Set 1: > Patch Set 1: > > Does warn checking (if warns are found) mean job will fail? Yes. > Why do we have it disabled by default but we seem to enable it everywhere > here? Or it's because we don't enable it in OBS? I lack some explanation > regarding those matters. We don't want to have this check enabled in OBS, because we are building for different distros with different asciidoc versions. These may throw different warnings than the asciidoc version installed in jenkins, and then unexpectedly fail the build because of a warning that jenkins did not report. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/15029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8775d45b4dc1a5a46e2ba042fc7ee7d9f10f18cc Gerrit-Change-Number: 15029 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Wed, 21 Aug 2019 11:20:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
