osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/15031 )
Change subject: Makefile.asciidoc.inc: warnings check not default ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15031/1/build/Makefile.asciidoc.inc File build/Makefile.asciidoc.inc: https://gerrit.osmocom.org/#/c/15031/1/build/Makefile.asciidoc.inc@79 PS1, Line 79: if [ -n "$$ASCIIDOC_WARNINGS_CHECK" ]; then \ > I guess the ratioanle is that "make check" currently only relates to whether > our unit tests pass. Before this patch, ./configure --enable-manuals and "make check" would always check the manuals too. That is due to how automake works, it finds the "check" rule and runs it in the subdirectory. With the patch, this behavior is overwritten and now the checks only run with "ASCIIDOC_WARNINGS_CHECK=1 make check". > I'm sure that some years down the road asciidoc has more warnings than today, > and you wouldn't be able to pass a "make check" anymore, which in turn makes > people believe that the software is somehow broken. Yes, the warnings changing being asciidoc versions is the reason why I created the patch. Not only some years down the road, but also in OBS where we have various distros and asciidoc versions, some may print additional warnings that let the documentation check fail. The new logic is that we don't check for the documentation warnings in OBS or other regular builds, just in jenkins where we have one specific asciidoc version. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/15031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Iac993a0d1b17205397a1f1ef1a7bd3f9df739e36 Gerrit-Change-Number: 15031 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Wed, 21 Aug 2019 11:32:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
