pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15256 )
Change subject: ggsn_vty.c: Improve output of VTY show pdp-context ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15256/2/ggsn/ggsn_vty.c File ggsn/ggsn_vty.c: https://gerrit.osmocom.org/#/c/15256/2/ggsn/ggsn_vty.c@762 PS2, Line 762: if (!pdp->secondary) { > (consider writing the non-inverted condition first) I'd prefer keeping it this way since it's the "main" branch, since pdp contexts are mostly primary. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: If9682fe343e9a1e78175a12538fb80d4bda54802 Gerrit-Change-Number: 15256 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: osmith <[email protected]> Gerrit-Comment-Date: Wed, 28 Aug 2019 09:07:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Gerrit-MessageType: comment
