dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15303 )
Change subject: mncc: do not unregister unregistered osmo fds ...................................................................... Patch Set 3: (2 comments) I have tested it and it seems that the close_connection() is indeed called twice in this situation. I now mark the fd as closed by setting it to -1 and then I check on that. If it is -1, the function exits immediately. https://gerrit.osmocom.org/#/c/15303/2/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/15303/2/src/mncc.c@327 PS2, Line 327: if (osmo_fd_is_registered(&conn->fd)) > Just wondering, we are also unconditionally closing conn->fd.fd. Can it > happen that fd. […] Done https://gerrit.osmocom.org/#/c/15303/2/src/mncc.c@329 PS2, Line 329: close(conn->fd.fd); > the normal solution employed in various other examples is to set 'conn->fd.fd > = -1" at every close. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I9742f31a37296fed15d54cf44c1f65b93abb8c8e Gerrit-Change-Number: 15303 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: laforge <lafo...@gnumonks.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 29 Aug 2019 08:32:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: laforge <lafo...@gnumonks.org> Gerrit-MessageType: comment
