laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15366 )
Change subject: HLR: Add test for generating EPS (LTE) tuples with separation bit == 1 ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/15366/1/hlr/HLR_Tests.ttcn File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/#/c/15366/1/hlr/HLR_Tests.ttcn@408 PS1, Line 408: GSUP.send(ts_GSUP_SAI_REQ_EPS(imsi)); > What about adding is_eps as a parameter to ts_GSUP_SAI_REQ_EPS()? it is easier to do it as-is. https://gerrit.osmocom.org/#/c/15366/1/hlr/HLR_Tests.ttcn@742 PS1, Line 742: /* TODO: match if tuple[s] matches expectation */ > I think you can drop this TODO since matching is done inside f_ensure_*() we're only matching that particular separation bit, but not the actual content of the tuple itself (i.e. the AUTN generation, ... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15366 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I40c6cf7e28ad9331e6c27fe7acafa3f9e277eedf Gerrit-Change-Number: 15366 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Sat, 31 Aug 2019 10:46:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
