laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15364 )
Change subject: AUC: Add support for setting the AMF separation bit to '1' for EUTRAN ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15364/1/src/hlr.c File src/hlr.c: https://gerrit.osmocom.org/#/c/15364/1/src/hlr.c@245 PS1, Line 245: if (gsup->rat_types_len >= 1 && gsup->rat_types[0] == OSMO_RAT_EUTRAN_SGS) > Can it be that EUTRAN is not in rat_types[0] but in another index? "per common sense" we will only have one RAT type in the UpdateLocation, as the LU REQ has arrived over one RAT type, and not over multiple at the same time. Multiple elements in the rat_types array is only used in the "insert subscriber data" (AFAIR), where the HLR can restrict the RAT types a MS/UE may use. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/15364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ic766bc40f6126bb479bd0a05b0e96bec3e240008 Gerrit-Change-Number: 15364 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Sat, 31 Aug 2019 10:49:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
