laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/15173 )
Change subject: gprs_gmm: clarify comment of Iu follow-on request
......................................................................
gprs_gmm: clarify comment of Iu follow-on request
Change-Id: Ib6b3a1b250de373656310a3c8f88d1d39bdcee60
---
M src/gprs/gprs_gmm.c
1 file changed, 10 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index d232156..185cd9a 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -1404,7 +1404,11 @@
goto err_inval;
cur += msnc_len;
- /* TODO: In iu mode - handle follow-on request */
+ /* TODO: In iu mode - handle follow-on request.
+ * The follow-on request can be signaled in an Attach Request on IuPS.
+ * This means the MS/UE asks to keep the PS connection open for further
requests
+ * after the Attach Request succeed.
+ * The SGSN can decide if it close the connection or not. Both are spec
conform. */
/* aTTACH Type 10.5.5.2 */
att_type = *cur++ & 0x07;
@@ -1742,7 +1746,11 @@
enum gsm48_gmm_cause reject_cause = GMM_CAUSE_PROTO_ERR_UNSPEC;
int rc;
- /* TODO: In iu mode - handle follow-on request */
+ /* TODO: In iu mode - handle follow-on request.
+ * The follow-on request can be signaled in an Attach Request on IuPS.
+ * This means the MS/UE asks to keep the PS connection open for further
requests
+ * after the Attach Request succeed.
+ * The SGSN can decide if it close the connection or not. Both are spec
conform. */
/* Update Type 10.5.5.18 */
upd_type = *cur++ & 0x07;
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15173
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ib6b3a1b250de373656310a3c8f88d1d39bdcee60
Gerrit-Change-Number: 15173
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
