laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-ggsn/+/15368 )
Change subject: gtp_error_ind_conf(): fix: guard against an unknown GTP version
......................................................................
gtp_error_ind_conf(): fix: guard against an unknown GTP version
This change fixes the following compiler warnings (found by Clang):
gtp.c:2747:13: warning: variable 'pdp' is used uninitialized
whenever 'if' condition is false
[-Wsometimes-uninitialized]
} else if (version == 1) {
gtp.c:2781:14: note: uninitialized use occurs here
OSMO_ASSERT(pdp);
^^^
Shall not happen in general, but let's make Clang happy.
Change-Id: Id471b22afd4c45435589a4edda0a804e66be3a7a
---
M gtp/gtp.c
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/gtp/gtp.c b/gtp/gtp.c
index 7cb82b6..3979165 100644
--- a/gtp/gtp.c
+++ b/gtp/gtp.c
@@ -2743,6 +2743,9 @@
GTP_LOGPKG(LOGL_ERROR, peer, pack, len, "Unknown PDP
context\n");
return EOF;
}
+ } else {
+ LOGP(DLGTP, LOGL_ERROR, "Unknown version: %d\n", version);
+ return EOF;
}
GTP_LOGPKG(LOGL_ERROR, peer, pack, len,
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15368
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Id471b22afd4c45435589a4edda0a804e66be3a7a
Gerrit-Change-Number: 15368
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
