pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15360 )

Change subject: src/gprs/Makefile.am: Move build of shared .c files to an 
internal lib
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/15360/2/src/gprs/Makefile.am
File src/gprs/Makefile.am:

https://gerrit.osmocom.org/#/c/15360/2/src/gprs/Makefile.am@55
PS2, Line 55: $(LIBCARES_LIBS) \
> Duplicate, see above.
Thanks, I'll remove it.


https://gerrit.osmocom.org/#/c/15360/2/src/gprs/Makefile.am@56
PS2, Line 56: lrt
> Do we really need it?
Probably it's not needed, I'll try dropping it.



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15360
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ib7665c530c086a5f3135c395bb8bf19ed4a882b6
Gerrit-Change-Number: 15360
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Comment-Date: Mon, 02 Sep 2019 12:01:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to