fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15385 )
Change subject: Implement GMM State using osmocom FSM ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15385/1/include/osmocom/sgsn/gprs_gmm_state_fsm.h File include/osmocom/sgsn/gprs_gmm_state_fsm.h: https://gerrit.osmocom.org/#/c/15385/1/include/osmocom/sgsn/gprs_gmm_state_fsm.h@6 PS1, Line 6: gmm_state_fsm_states I find this naming confusing: 'state FSM states'? Maybe it's time to drop this 'state' prefix since you're rewriting the code anyway? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Idecb43c10d66224d4f9ba9320825040ce6cf9a07 Gerrit-Change-Number: 15385 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 02 Sep 2019 15:46:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
