laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15353 )
Change subject: Introduce FSM mm_state_gb_fsm ...................................................................... Patch Set 2: I beg to disagree. Why are we writign new code before we have any way of testing it in an automatic way? And not only writing the code, but actually submitting it for inclusion/merge? There's no problem if the test cases will mostly fail due to problems in the old code, and hopefully will gradually start to pass as more new code gets merged. But by not having the tests *before* a rewrite, you will never get around writing them. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15353 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I04004423e993107374d5a3549b8a93ac169251dd Gerrit-Change-Number: 15353 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Mon, 02 Sep 2019 20:23:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
