lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15161 )
Change subject: iu_client: introduce ranap_iu_free_ue() to free the UE connections ...................................................................... Patch Set 8: (2 comments) https://gerrit.osmocom.org/#/c/15161/8/src/iu_client.c File src/iu_client.c: https://gerrit.osmocom.org/#/c/15161/8/src/iu_client.c@139 PS8, Line 139: osmo_sccp_tx_disconn(g_scu, ue_ctx->conn_id, NULL, 0); > I don't really like the idea of calling tx_disconn inside free() function, > imho tx_disconn should be […] So far, the SGSN doesn't know so much about sccp connection (since 2g isn't connection oriented). The sccp connection has the same lifetime as this object, since only connected objects makes sense. Unconnected objects should only be present while the cleanup in sgsn happens. https://gerrit.osmocom.org/#/c/15161/8/src/iu_client.c@816 PS8, Line 816: /* A Iu Release event might be used to free the UE in cn_ranap_handle_co. */ > This seems not related to the patch? yes, it's related. it's not needed here, because ue is not used further in this function. In ranap_cn_rx_co() a call towards ranap_iu_free_ue() can happen. I'll move this into the emit signal patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I6812edb4da487507ccf9f483de801c1c65c4b72b Gerrit-Change-Number: 15161 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@gnumonks.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2019 16:32:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
