lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-iuh/+/15179 )

Change subject: iu_client: sccp_sap_up: set rc early
......................................................................

iu_client: sccp_sap_up: set rc early

Allows to skip assignment later.

Change-Id: Idd803774612719df144bef569fb734289aa31282
---
M src/iu_client.c
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved
  laforge: Looks good to me, approved



diff --git a/src/iu_client.c b/src/iu_client.c
index 92d25f5..b5f3557 100644
--- a/src/iu_client.c
+++ b/src/iu_client.c
@@ -764,7 +764,7 @@
        struct osmo_sccp_user *scu = _scu;
        struct osmo_scu_prim *prim = (struct osmo_scu_prim *) oph;
        struct osmo_prim_hdr *resp = NULL;
-       int rc;
+       int rc = -1;
        struct ranap_ue_conn_ctx *ue;
        struct new_ue_conn_ctx new_ctx = {};

@@ -773,7 +773,6 @@
        switch (OSMO_PRIM_HDR(oph)) {
        case OSMO_PRIM(OSMO_SCU_PRIM_N_CONNECT, PRIM_OP_CONFIRM):
                /* confirmation of outbound connection */
-               rc = -1;
                break;
        case OSMO_PRIM(OSMO_SCU_PRIM_N_CONNECT, PRIM_OP_INDICATION):
                /* indication of new inbound connection request*/
@@ -814,7 +813,6 @@
                rc = ranap_cn_rx_cl(cn_ranap_handle_cl, prim, 
msgb_l2(oph->msg), msgb_l2len(oph->msg));
                break;
        default:
-               rc = -1;
                break;
        }


--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15179
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: Idd803774612719df144bef569fb734289aa31282
Gerrit-Change-Number: 15179
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lyn...@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@gnumonks.org>
Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged

Reply via email to