pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15180 )
Change subject: iu_client: sccp_sap_up: don't decode empty disconnect indications ...................................................................... Patch Set 5: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/15180/5/src/iu_client.c File src/iu_client.c: https://gerrit.osmocom.org/#/c/15180/5/src/iu_client.c@802 PS5, Line 802: rc = 0; I hope at some point this "rc = 0" is moved up in order to set rc if !ue condition is hit, otherwise it looks like rc will be returned uninitialized. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900 Gerrit-Change-Number: 15180 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Tue, 03 Sep 2019 17:43:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
