pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 )
Change subject: sgsn: add TC_geran_attach_iu_rau ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/15397/1/sgsn/SGSN_Tests_Iu.ttcn File sgsn/SGSN_Tests_Iu.ttcn: https://gerrit.osmocom.org/#/c/15397/1/sgsn/SGSN_Tests_Iu.ttcn@57 PS1, Line 57: private function f_TC_geran_attach_iu_rau(charstring id) runs on BSSGP_ConnHdlr { Again, write a description on top of function about what does the test check please. https://gerrit.osmocom.org/#/c/15397/1/sgsn/SGSN_Tests_Iu.ttcn@74 PS1, Line 74: vc_conn.done; Missing f_cleanup(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef Gerrit-Change-Number: 15397 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Tue, 03 Sep 2019 18:42:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
