laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15376 )
Change subject: bsc: Test suite for CBSP (Cell Broadcast Service Protocol) ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/15376/2/bsc/BSC_Tests_CBSP.ttcn File bsc/BSC_Tests_CBSP.ttcn: https://gerrit.osmocom.org/#/c/15376/2/bsc/BSC_Tests_CBSP.ttcn@94 PS2, Line 94: activate(as_IgnRSL((tr_RSL_BCCH_INFO, tr_RSL_SACCH_FILL, > In the as_IgnRSL I see one template needs to be passed, but you seem to be > passing some sort of arra […] you can always create a "choice" of templates by putting the alternatives in parenthesis. So the template "(a, b, c)" means: Either a, or b, or c will match. Works in every context where a template is required. Basically you form a new template in-line using other templates. https://gerrit.osmocom.org/#/c/15376/2/bsc/BSC_Tests_CBSP.ttcn@126 PS2, Line 126: //[] CBSP[0].receive(tr_CBSP_Recv(?, tr_CBSP_RESTART(?, CBSP_BC_MSGT_EMERG, CBSP_RI_DATA_LOST))); > This line can be dropped? I'm not sure what is the best to expect here as per spec. I'll add a related comment. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia6ffac181f50586d06d2f29bca1c57285179e861 Gerrit-Change-Number: 15376 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Thu, 05 Sep 2019 11:14:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
