osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15430 )

Change subject: PCU_Tests_RAW.ttcn: initial version of component RAW_PCU_BTS_CT
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Looks good to me! I'm surprised with how few lines of code this could be 
implemented.

https://gerrit.osmocom.org/#/c/15430/1/pcu/PCU_Tests_RAW.ttcn
File pcu/PCU_Tests_RAW.ttcn:

https://gerrit.osmocom.org/#/c/15430/1/pcu/PCU_Tests_RAW.ttcn@552
PS1, Line 552: tuwat
Maybe give it a more descriptive name like "selftest"? ;)



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15430
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I63a23abebab88fd5318eb4d907d6028e7c38e9a3
Gerrit-Change-Number: 15430
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilira...@gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilira...@gmail.com>
Gerrit-Reviewer: laforge <lafo...@gnumonks.org>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Comment-Date: Fri, 06 Sep 2019 07:08:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to