laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15444 )
Change subject: SMSCB: Send ETWS Primary Notifiation via RSL to BTS ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15444/2/src/osmo-bsc/smscb.c File src/osmo-bsc/smscb.c: https://gerrit.osmocom.org/#/c/15444/2/src/osmo-bsc/smscb.c@513 PS2, Line 513: LOGL_ERROR > Looks more like a NOTICE. I think it deserves ERROR level. Basically this means that the CBC is asking us to broadcast an emergency message in a BTS which doesn't support it. It shouldn't do that, and as this is about emergency notification in case of natural desasters, anything that goes wrong is an error. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7e45b0373458a4348b12b92dd92861062532548b Gerrit-Change-Number: 15444 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Comment-Date: Sat, 07 Sep 2019 16:04:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
