pespin has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-pcu/+/15510 )
Change subject: bts.cpp: Fix osmo_tdef initialization on older g++ compilers
......................................................................
bts.cpp: Fix osmo_tdef initialization on older g++ compilers
Fixing errrors spotted:
bts.cpp:78:1: error: uninitialized const member 'osmo_tdef::T'
};
^
bts.cpp:78:1: error: uninitialized const member 'osmo_tdef::default_val'
bts.cpp:78:1: error: uninitialized const member 'osmo_tdef::unit'
bts.cpp:84:1: error: uninitialized const member 'osmo_tdef::T'
};
^
bts.cpp:84:1: error: uninitialized const member 'osmo_tdef::default_val'
bts.cpp:84:1: error: uninitialized const member 'osmo_tdef::unit'
Change-Id: I2dfecf22516f52cc19e0a0442e70dbc4dbc61336
---
M src/bts.cpp
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
osmith: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/bts.cpp b/src/bts.cpp
index a913ca0..8b32e2e 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -74,13 +74,13 @@
{ .T=3191, .default_val=5, .unit=OSMO_TDEF_S, .desc="Reuse of TFI(s)
after sending (1) last RLC Data Block on TBF(s), or (2) PACKET TBF RELEASE for
an MBMS radio bearer (s)", .val=0 },
{ .T=3193, .default_val=100, .unit=OSMO_TDEF_MS, .desc="Reuse of TFI(s)
after reception of final PACKET DOWNLINK ACK/NACK from MS for TBF (ms)", .val=0
},
{ .T=3195, .default_val=5, .unit=OSMO_TDEF_S, .desc="Reuse of TFI(s)
upon no response from the MS (radio failure or cell change) for TBF/MBMS radio
bearer (s)", .val=0 },
- {}
+ { .T=0, .default_val=0, .unit=OSMO_TDEF_S, .desc=NULL, .val=0 } /*
empty item at the end */
};
static struct osmo_tdef T_defs_pcu[] = {
{ .T=-2000, .default_val=2, .unit=OSMO_TDEF_MS, .desc="Tbf reject for
PRR timer (ms)", .val=0 },
{ .T=-2001, .default_val=2, .unit=OSMO_TDEF_S, .desc="PACCH
assignment timer (s)", .val=0 },
{ .T=-2002, .default_val=200, .unit=OSMO_TDEF_MS, .desc="Waiting after
IMM.ASS confirm timer (ms)", .val=0 },
- {}
+ { .T=0, .default_val=0, .unit=OSMO_TDEF_S, .desc=NULL, .val=0 } /*
empty item at the end */
};
/**
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15510
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I2dfecf22516f52cc19e0a0442e70dbc4dbc61336
Gerrit-Change-Number: 15510
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
