lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15486 )

Change subject: gprs_mm_state_gb_fsm: ensure T3350 is not running when entering 
IDLE
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/15486/2/src/sgsn/gprs_mm_state_gb_fsm.c
File src/sgsn/gprs_mm_state_gb_fsm.c:

https://gerrit.osmocom.org/#/c/15486/2/src/sgsn/gprs_mm_state_gb_fsm.c@24
PS2, Line 24:   if (ctx->T == 3350 && osmo_timer_pending(&ctx->timer))
> When is this timer set? in both MM_STANDBLY and READY? we should probably 
> move it to osmo_tdef in th […]
This timer is started by the "old" RAU code which doesn't have yet a fsm.



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15486
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ibdd913173af11d0e6d04aa392e047d5d9aee1243
Gerrit-Change-Number: 15486
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lyn...@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@gnumonks.org>
Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Sep 2019 12:38:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to