pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15550 )
Change subject: vty: add "logging filter l1-sapi" ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15550/1/src/common/vty.c File src/common/vty.c: https://gerrit.osmocom.org/#/c/15550/1/src/common/vty.c@1607 PS1, Line 1607: uint16_t parse_l1_sapi_str(const char *sapi) { Looks like you want a value_string here instead of this if+else. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15550 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I32d86d3d34757135b4cce59919c2fc2b67f0a889 Gerrit-Change-Number: 15550 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 17 Sep 2019 15:29:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment