osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15601 )
Change subject: pdch.cpp: Use pcu_l1_meas previously filled by lower layers ...................................................................... Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/15601/1/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/#/c/15601/1/src/pdch.cpp@376 PS1, Line 376: void gprs_rlcmac_pdch::rcv_control_dl_ack_nack(Packet_Downlink_Ack_Nack_t *ack_nack, uint32_t fn, struct pcu_l1_meas *meas) line > 120 characters https://gerrit.osmocom.org/#/c/15601/1/src/pdch.cpp@442 PS1, Line 442: void gprs_rlcmac_pdch::rcv_control_egprs_dl_ack_nack(EGPRS_PD_AckNack_t *ack_nack, uint32_t fn, struct pcu_l1_meas *meas) line length -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15601 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I1980ca325c8d65f3f6310fa697dd810eec7ab077 Gerrit-Change-Number: 15601 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Thu, 26 Sep 2019 11:29:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
